Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60889/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line 4725: extendDrivesIfNeeded
why do you want to run all over all the drives (like
extendDrivesIfNeeded()
Let me calrify a bit. In the commit message you state:
"We can use this information during an active live merge operation to perform
on-demand extension of the merge target (just as we already do for the active layer). When
libvirt does not provide the necessary information, use a preemptive extension
instead."
and this is fine, but I think we know exactly which drives we need to extend, no need to
run over all of them - right?
To summarize, I think it is better to avoid to run too generic code in this flow, and be
more specific, avoiding unneeded work.
--
To view, visit
https://gerrit.ovirt.org/60889
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes