Change in vdsm[master]: check-merged: split functions by logic and few nits

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: split functions by logic and few nits
......................................................................


Patch Set 9: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/70825/9/automation/check-merged.sh
File automation/check-merged.sh:

PS9, Line 9: Fix when running in an el* chroot in fc2* host
I don't understand this comment.

is this a fix? or should we fix this?


Line 125:     lago stop "$VM_NAME"
Line 126:     lago cleanup
Line 127: }
Line 128: 
Line 129: function quit {
it feels like what you need is

 trap collect_and_clean EXIT
Line 130:     collect_logs
Line 131:     cleanup
Line 132:     exit $0
Line 133: }


PS9, Line 136: if [ $? -ne 0 ]; then
             :     echo 'check-merged.sh: ERROR during setup_env'
             :     quit 1
             : fi
does this work? the script is running with -e, so the script would explode on the very
first non-zero return value, and would never get to here.


-- 
To view, visit https://gerrit.ovirt.org/70825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74f9326289b972abaef4507ab4d2582a8d641778
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com&gt;
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes