Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 184:
Line 185: return QemuImgOperation(cmd, cwd=cwdPath)
Line 186:
Line 187:
Line 188: def commit(top, topFormat=None, base=None):
We should require topFormat, more secure to never let qemu detect the
forma
I think topFormat should be baseFormat. qemu-img does not specify what is the
-f fmt argument, but it cannot be the top format since the top must be qcow image to be a
"top" image.
Since qemu allow fmt as optional parameter, lest keep it as optional. This is also more
consistent with other functions in this module.
Line 189: cmd = [_qemuimg.cmd, "commit", "-p"]
Line 190: cwdir = None
Line 191:
Line 192: if base:
--
To view, visit
https://gerrit.ovirt.org/64222
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes