Eduardo has posted comments on this change.
Change subject: Raise specific exception when local path not exist
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Please explain which issue are you trying to solve.
Raising specific exceptions is a very bad practice.
The mount will fail anyway and the OSError is descriptive enough.
Changing the responses of the engine based on specific exceptions is a disaster recipe and
should be avoided since such entanglement is fixing forever the vdsm code, making
impossible any improvement.
....................................................
File vdsm/storage/storageServer.py
Line 462: return os.path.join(self.localPathBase,
Line 463: self._path.replace("_",
"__").replace("/", "_"))
Line 464:
Line 465: def checkTarget(self):
Line 466: if not os.path.exists(self._path) or not os.path.isdir(self._path):
Nothing was removed. Your checks are still there.
Line 467: raise se.StorageServerLocalNotDirError(self._path)
Line 468: fileSD.validateDirAccess(self._path)
Line 469: return True
Line 470:
--
To view, visit
http://gerrit.ovirt.org/13724
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9310e3895e30fa5b2ae9a092aa4c1fef508c8e96
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes