Yaniv Kaul has posted comments on this change.
Change subject: virt: enable glusterfs access through libgfapi interface ......................................................................
Patch Set 8:
(1 comment)
I'm quite sure this patch has to depend on the cluster level being 4.1 or above (i.e, RHEL 7.3 and above), no? We don't want older hosts without this mixed with newer hosts with this functionality, or is it local to the host? Will live migration and live storage migration work between old and new host?
https://gerrit.ovirt.org/#/c/44061/8/vdsm/clientIF.py File vdsm/clientIF.py:
Line 321: if drive.get('diskType') == DISK_TYPE.NETWORK: Line 322: volinfo = res['info'] Line 323: volPath = volinfo['path'] Line 324: drive['protocol'] = volinfo['protocol'] Line 325: # currently, single host is provided due to this bug: since this patch is for 4.1, and 4.1 will be on top of 7.3, I think we need to remove this limitation. Line 326: # https://bugzilla.redhat.com/1247521 Line 327: drive['hosts'] = [volinfo['hosts'][0]] Line 328: else: Line 329: volPath = res['path']