Bala.FA has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
......................................................................
Patch Set 17: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/18414/17/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1201: raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
Line 1202:
Line 1203:
Line 1204: @makePublic
Line 1205: def volumeGeoRepStatusDetail(volumeName, remoteHost, remoteVolumeName):
volumeGeoRepStatus() should do 'detail', not as separate function. Please check
volumeStatus() how it handles such situation
Line 1206: command = _getGlusterVolGeoRepCmd() + [volumeName, "%s::%s" % (
Line 1207: remoteHost, remoteVolumeName), "status", "detail"]
Line 1208: try:
Line 1209: xmltree = _execGlusterXml(command)
--
To view, visit
http://gerrit.ovirt.org/18414
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes