Francesco Romani has posted comments on this change.
Change subject: vdsm hostdev: add support for SCSI devices
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/29058/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3202: # @startupPolicy: #optional Possible boot handling with attached device
Line 3203: # (for @usb)
Line 3204: #
Line 3205: # @shareable: #optional If present, this indicates the device is
Line 3206: # expected to be shared between domains (for @scsi)
second line is underindented
Line 3207: #
Line 3208: # @readonly: #optional If present, indicates that the device is read
Line 3209: # only (for @scsi)
Line 3210: #
Line 3205: # @shareable: #optional If present, this indicates the device is
Line 3206: # expected to be shared between domains (for @scsi)
Line 3207: #
Line 3208: # @readonly: #optional If present, indicates that the device is read
Line 3209: # only (for @scsi)
ditto
Line 3210: #
Line 3211: # Since: 4.16.0
Line 3212: ##
Line 3213: {'type': 'HostDeviceSpecParams',
http://gerrit.ovirt.org/#/c/29058/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1746:
source.setAttrs(startupPolicy=self.specParams['startupPolicy'])
Line 1747:
Line 1748: elif self.capability == 'scsi':
Line 1749: source.appendChildWithArgs('address', None,
Line 1750: **self.getScsiHost())
getScsiAddr maybe? or maybe rename getScsiAddr to getScsiHost
Line 1751: source.appendChildWithArgs('adapter', None,
Line 1752: **self.getScsiAdapter())
Line 1753:
Line 1754: if 'readonly' in self.specParams:
--
To view, visit
http://gerrit.ovirt.org/29058
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia953bcd5eda1b97235a8dd2f5f9593d8f302e5d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes