Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 75:
Line 76: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 77: DUMMY_BRIDGE = ';vdsmdummy;'
Line 78: DEFAULT_MTU = '1500'
Line 79: MAX_BOND_NAME_LENGTH = 15
Maybe I was blind but I could not find a constant to use, maybe it should be the other way
around. The one in vdsm/netmodels.py is a member of the Bridge class.
Line 80:
Line 81: REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2',
'bond3', 'bond4'))
Line 82:
Line 83: _Qos = namedtuple('Qos', 'inbound outbound')
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes