Dan Kenigsberg has posted comments on this change.
Change subject: Add the REST API bindings
......................................................................
Patch Set 1: (5 inline comments)
....................................................
Commit Message
Line 7: Add the REST API bindings
some claim that Python is clearer than English, but I would prefer a short introduction of
the new capability, a sketch of its architecture, and an explanation of its use.
....................................................
File vdsm/config.py.in
Line 227: 'clients.'),
unexpanded tabs?! the horror.
....................................................
File vdsm/rest/Controller.py
Line 62: class restException(Exception):
Class starting with a lower case? (don't copy the bad things we have)
Line 76: print d
logging?
....................................................
File vdsm/rest/Store/LocalDB.py
Line 21: class LocalDB(StorageDriver):
is this file intentionally included?
I would prefer to have a separate discussion regarding local DB, as the concept conflicts
with that of ovirt-Engine-owned DB.
--
To view, visit
http://gerrit.ovirt.org/2021
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>