Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/45077/7//COMMIT_MSG
Commit Message:
Line 21: hotplugging is performed and succeeds, then monitoring is resumed and
Line 22: sets the disk to be still plugged, this patch is critical for the
Line 23: engine to be synced with the actual state of the VM's disks.
Line 24:
Line 25: Please note that this patch is partial, as deatchDevice is async. That
/s/deatch/detach
Done, thanks!
Line 26: means that still the hash can be calculated wrong in case the disk was
Line 27: not detached yet. This fix will be included in a following patch.
Line 28:
Line 29: Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d
--
To view, visit
https://gerrit.ovirt.org/45077
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes