Bala.FA has posted comments on this change.
Change subject: gluster: geo-replication configuration related verbs.
......................................................................
Patch Set 7: Code-Review-1
(5 comments)
http://gerrit.ovirt.org/#/c/30162/7//COMMIT_MSG
Commit Message:
Line 13: * glusterVolumeGeoRepConfigList
Line 14: - Lists all the configuration for the session.
Line 15: Returns:
Line 16: {georepConfig:[{'optionName': configuration name,
Line 17: 'optionValue': value}]}
You could have something like
{'geoRepConfig': {'option': 'value, ...}}
Line 18:
Line 19: * glusterVolumeGeoRepConfigSet
Line 20: - Sets the configuration value for a given
Line 21: configuration.
http://gerrit.ovirt.org/#/c/30162/7/client/vdsClientGluster.py
File client/vdsClientGluster.py:
Line 532: params = self._eqSplit(args)
Line 533: volumeName = params.get('volumeName', '')
Line 534: remoteHost = params.get('remoteHost', '')
Line 535: remoteVolumeName = params.get('remoteVolumeName', '')
Line 536: key = params.get('key', '')
you could have 'option' instead of 'key'
Line 537: value = params.get('value', '')
Line 538:
Line 539: status = self.s.glusterVolumeGeoRepConfigSet(volumeName,
Line 540: remoteHost,
Line 548: params = self._eqSplit(args)
Line 549: volumeName = params.get('volumeName', '')
Line 550: remoteHost = params.get('remoteHost', '')
Line 551: remoteVolumeName = params.get('remoteVolumeName', '')
Line 552: key = params.get('key', '')
same here
Line 553:
Line 554: status = self.s.glusterVolumeGeoRepConfigReset(volumeName,
Line 555: remoteHost,
Line 556: remoteVolumeName,
Line 938: serv.do_glusterVolumeGeoRepConfigSet,
Line 939: ('volumeName=<volume_name> '
Line 940: 'remoteHost=<remote_host> '
Line 941: 'remoteVolumeName=<remote_volume_name> '
Line 942: 'key=<option_name>'
same here
Line 943: 'value=<option_value>'
Line 944: '<remote_host> is IP/dns name of host in remote Gluster
cluster.'
Line 945: '<remote_volume_name> volume name in remote gluster
cluster.',
Line 946: 'set a geo-replication configuration for a session'
Line 949: serv.do_glusterVolumeGeoRepConfigReset,
Line 950: ('volumeName=<volume_name> '
Line 951: 'remoteHost=<remote_host> '
Line 952: 'remoteVolumeName=<remote_volume_name> '
Line 953: 'key=<option_name>'
same here
Line 954: '<remote_host> is IP/dns name of host in remote Gluster
cluster.'
Line 955: '<remote_volume_name> volume name in remote gluster
cluster.',
Line 956: 'Reset a geo-replication configuration to its default
value'
Line 957: ))
--
To view, visit
http://gerrit.ovirt.org/30162
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee571dbf3c56633e415d32f8d518cb64aaf1add
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes