Saggi Mizrahi has posted comments on this change.
Change subject: storagePool: Reject unknown method in uploadVolume
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1980: self.log.error("uploadVolume - method '%s' not
supported" % method)
My complaint is not the same as your pettiness.
When letting the logging infra to do the formatting you actually avoid formatting if that
log level is disabled. If you format outside logging you still pay the performance price
for the string formatting even if the line will never be printed.
This is, in fact, the reason why all the logging methods have their own formatting
ability.
--
To view, visit
http://gerrit.ovirt.org/671
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>