Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/8/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1188: {'nics': nics[1:],
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different from
default
Line 1192: self.assertIn(BONDING_NAME, self.vdsm_net.netinfo.bondings)
This is not the assertion I requested. You need to verify that
[BONDING_ NA
I will check on my RHEL6.5 host what to actually expect because the
default mode is 0, not 4...
Line 1193: opts =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['options']
Line 1194: self.assertEqual(opts, {'miimon': ['9']})
Line 1195:
Line 1196: # cleanup
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-HasComments: Yes