Nir Soffer has posted comments on this change.
Change subject: tox: added disable tox style validation option to Makefile
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59417/2//COMMIT_MSG
Commit Message:
Line 10: variable that disables tox run.
Line 11: This option is useful for developers who encounter issues running tox
Line 12: on their environment and want to skip tox style validation.
Line 13: use it by the following:
Line 14: make check DISABLE_STYLE_VALIDATION=1
Why do we need to disable style check?
Adding this flag is clumsy, and make it harder to use the build system.
What we need instead is a new target for running the *only* the tests. If we have such
target, a developer can run exactly what she wants:
make python3 unitests # everything but style checks
Or
make pep8 pyflakes # only style checks
Line 15:
Line 16: Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
--
To view, visit
https://gerrit.ovirt.org/59417
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes