Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45429/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:
Line 66: def prepare_args(self, className, methodName, args, kwargs):
Line 67: sym = self._vapi['commands'][className][methodName]
Line 68: allargs = sym.get('data', {}).keys()
Line 69: allargs = [arg[1:] if arg.startswith('*') else arg for arg in
allargs]
Line 70: params = dict(zip(allargs, args))
Good point, we need to use orederd dict.
I doubled check schema
parser and we already use ordered dict.
Line 71: params.update(kwargs)
Line 72: return params
Line 73:
Line 74: def _callMethod(self, methodName, *args, **kwargs):
--
To view, visit
https://gerrit.ovirt.org/45429
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibac6eab3c519becb29d2b3551111d671bbb79df5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes