Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 722: self._wait_for_process()
Line 723:
Line 724: if self._proc.returncode != 0:
Line 725: raise V2VProcessError('Job %r process failed exit-code:
%r' %
Line 726: (self._id,
This doesn't realy work now that traces are included in the output and served only for
logging on engine side. Now that we have full logs on vdsm side it's not necessary
anyway.
Line 727: self._proc.returncode))
Line 728:
Line 729: if self._status != STATUS.ABORTED:
Line 730: self._status = STATUS.DONE
--
To view, visit
https://gerrit.ovirt.org/59834
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes