Adam Litke has posted comments on this change.
Change subject: Live Merge: Extend internal block volumes during merge
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31268/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2093: self.log.debug('new rtc offset %s', newTimeOffset)
Line 2094: with self._confLock:
Line 2095: self.conf['timeOffset'] = newTimeOffset
Line 2096:
Line 2097: def _getLiveMergeExtendCandidates(self):
any reason to drop the _getMergeWriteWatermarks() helper?
None,
really. I'll add it back.
Line 2098: ret = {}
Line 2099:
Line 2100: # The common case is that there are no active jobs.
Line 2101: if not self.conf['_blockJobs'].values():
--
To view, visit
http://gerrit.ovirt.org/31268
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a9e0ebdb9c42df713c40e0fc5782945eb7228a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes