Alon Bar-Lev has posted comments on this change.
Change subject: retire netstat
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Although it is correct, I don't like pulling netstat output in and tool to know if
port is free.
We can fail for 100000 other reason to start the daemon, so why check only that? I suggest
removing this check.
But if we want to keep it, a simple bind using 'python -c "import socket;
..."' is more appropriate, so we do not parse anything and get definite result.
--
To view, visit
http://gerrit.ovirt.org/9651
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8417ae3bb2f09404787cd8915984aaa6fb779e7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>