ShaoHe Feng has posted comments on this change.
Change subject: WIP storage: Alert for using vdsm.conf nfs_mount_options
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/storage_exception.py
Line 175:
Line 176:
Line 177: class MiscDeprecatedNFSOptions(StorageException):
Line 178: def __init__(self, options):
Line 179: self.value = "options=%s" % (options,)
only one format argument options. Does it need tuple?
how about:
self.value = "options=%s" % options
Line 180: code = 2009
Line 181: message = "Using deprecated nfs_mount_options parameter from
vdsm.conf."\
Line 182: " This parameter will continue to be supported in versions
3.x,"\
Line 183: " but may be removed in a future version of oVirt.
Please"\
--
To view, visit
http://gerrit.ovirt.org/8979
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8520238e0b41eb95d035128681dc3b71a953e644
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>