From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Introducing firewalld configurator
......................................................................
Patch Set 16: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/74883/16/lib/vdsm/tool/configurators/firewal...
File lib/vdsm/tool/configurators/firewalld.py:
Line 26: REQUIRED_SERVICES = (
Line 27: 'vdsm',
Line 28: 'libvirt',
Line 29: 'ssh',
Line 30: # TODO: add remaining services
at least, list the names or the ports that you need to open
Line 31: )
Line 32:
Line 33: try:
Line 34: from vdsm.gluster import api
PS16, Line 40: virt
I suppose you mean gluster services. here, too, please list those services that we
currently open via iptables.
--
To view, visit
https://gerrit.ovirt.org/74883
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9b5f533de0b609c15a2482b2fba0ae713c3c33
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes