Dan Kenigsberg has posted comments on this change.
Change subject: Fixing ssl config validation
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24500/1/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 46:
Line 47: get_libvirt_conf_item() {
Line 48: local cfile="$1"
Line 49: local key="$2"
Line 50: @GREP_PATH@ "^\s*"${key}"\s*=" "${cfile}"
>/dev/null 2>&1 | \
please squash Ic4cab6f3346f9b1ad492d40ea3d3c645484570da into this patch!
Line 51: tail -1 | @SED_PATH@
"s/\s*$key\s*=\s*//;s/\s*\(#.*\)\?$//"
Line 52: }
Line 53:
Line 54: test_conflicting_conf() {
--
To view, visit
http://gerrit.ovirt.org/24500
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9ada1b81d275b8cac9391c15ab903ec9552184
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-HasComments: Yes