Adam Litke has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
......................................................................
Patch Set 2:
Igor, thanks for your review. In looking at getAllTasksInfo() and getAllTasksStatuses() I
don't see how task info could be more expensive to get than task status. Today
getTaskInfo() simply returns task.name and getTaskStatus returns a dict of values:
self.id, self.state, self.code, self.message. Aside from the data they return, these two
functions seem to behave identically. If anything, this will improve performance in some
cases by eliminating the need for a second API call when you also want to task verb. Am I
missing something?
--
To view, visit
http://gerrit.ovirt.org/3613
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>