Change in vdsm[master]: vdsm hostdev: add support for SCSI devices

Francesco Romani has posted comments on this change.

Change subject: vdsm hostdev: add support for SCSI devices
......................................................................

Patch Set 5:

(2 comments)

initial comments

http://gerrit.ovirt.org/#/c/29058/5/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 55:         return {'type': addr['type'], 'bus': addr['bus'], 'target': addr['target'],
Line 56:                 'unit': addr['lun']}
Line 57: 
Line 58:     def getScsiAdapter(self):
Line 59:         host = 'scsi_host{0}'.format(self._parseCaps(['host'])['host'])
unneeded temporary
Line 60: 
Line 61:         return {'name': host}
Line 62: 
Line 63:     def _parseCaps(self, elements):

Line 70:             ret[element] = capsxml.getElementsByTagName(element)[0].\
Line 71:                 firstChild.nodeValue
Line 72: 
Line 73:             try:
Line 74:                 ret[element] = hex(int(ret[element]))
why do we need this dance?
Line 75:             except:
Line 76:                 pass
Line 77: 
Line 78:         return ret