mooli tayer has posted comments on this change.
Change subject: el6_tests: fix toolTests to use VdsmTestCase so that assertIn is
available
......................................................................
Patch Set 1: Verified-1
This fails[1] for me.
The reason is that tests/testlib.py[2] isn't available at 3.5.
There is also anther test failing[3] putting it here in case it
Means something to someone.
[1]
======================================================================
ERROR: Failure: ImportError (No module named testlib)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/nose/loader.py", line 364, in
loadTestsFromName
addr.filename, addr.module)
File "/usr/lib/python2.6/site-packages/nose/importer.py", line 39, in
importFromPath
return self.importFromDir(dir_path, fqname)
File "/usr/lib/python2.6/site-packages/nose/importer.py", line 84, in
importFromDir
mod = load_module(part_fqname, fh, filename, desc)
File "/root/rpmbuild/BUILD/vdsm-4.16.2/tests/toolTests.py", line 31, in
<module>
from testlib import VdsmTestCase
ImportError: No module named testlib
[2]
~/dev/vdsm (master)$ ll tests/testlib.py
-rw-rw-r--. 1 mtayer mtayer 12702 Aug 28 14:26 tests/testlib.py
~/dev/vdsm (master)$ git checkout ovirt-3.5
Switched to branch 'ovirt-3.5'
Your branch is up-to-date with 'origin/ovirt-3.5'.
~/dev/vdsm (ovirt-3.5)$ ll tests/testlib.py
ls: cannot access tests/testlib.py: No such file or directory
--
To view, visit
http://gerrit.ovirt.org/32103
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb564320db9db1b3349c7fbb87bc63a8a044c6b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No