Dan Kenigsberg has posted comments on this change.
Change subject: Fill volume children info.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/volume.py
Line 900: info['truesize'] = "0"
Line 901: info['mtime'] = "0"
Line 902: info['status'] = "INVALID"
Line 903:
Line 904: # Both engine and dumpStorageTable don't use this option so
You should dump or change the comment above. And better squash into the former patch.
Line 905: # only keeping it to not break existing scripts that look for the key
Line 906: info['children'] = list(self.getChildren())
Line 907:
Line 908: # If image was set to illegal, mark the status same
--
To view, visit
http://gerrit.ovirt.org/20004
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf374e6abe81962619baecf96fffa0f817ce5dcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes