Nir Soffer has posted comments on this change.
Change subject: misc: remove cp parameter
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45613/2/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 448: raise se.InvalidParameterException(name, number)
Line 449: return n
Line 450:
Line 451:
Line 452: def rotateFiles(directory, prefixName, gen, persist=False):
If it's used for backing up domain metadata why would you want me
to remove
This function does *nothing* since 2012 (since commit
8bc23a66b409f47e9b652f82c950e04e4816af19). The tests are also broken - they pass while the
function does nothing.
Since we are living happily without the domain metadata backup for about 3 years, we will
continue without it.
On node, this way of backup - keeping 30 copies and renaming all of them on each backup,
doing 30 unpresist and 30 persist operations per run is crazy.
Line 453: log.debug("dir: %s, prefixName: %s, versions: %s" %
Line 454: (directory, prefixName, gen))
Line 455: gen = int(gen)
Line 456: files = os.listdir(directory)
--
To view, visit
https://gerrit.ovirt.org/45613
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes