Dan Kenigsberg has posted comments on this change.
Change subject: [WIP]change startup process for vdsm and supervdsm
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
thanks for tackling this annoying issue! I wish vdsm startup is normalized.
however, replacing the general-porpose 'respawn' by a vdsm-specific non-trivial
script such as vdsmService is not quite the cleanup I was hoping for.
What is the motivation for your patch? Has it been accomplished in your opinion?
I would appreciate if you could keep 'respawn' (for EL6), and make it start
superVdsm. superVdsm can then fork, relinquish root, and exec vdsm. This is not trivial to
implement, since we would like superVdsm to die if vdsm crashes. But with this, the
'respawn' logic can be replace by systemd for Fedora or upstart in Debian.
In any case, I have not figured it all up; we may end up needing something as complex as
the current suggestion.
....................................................
File vdsm/storage/misc.py
Line 724: def retry(func, argList=[], expectedException=Exception, tries=None,
better use a tupple here.
....................................................
File vdsm/supervdsm.py
Line 51: raise
that's just like not handling the exception, but slower...
....................................................
File vdsm/vdsmService
Line 120: def respawn(cmd, sudo=True):
it took me some time to stabilize that bash code. what is the urgency to rewrite it in
Python? Note that modern distributions (aka Fedora) has systemd, which kinda makes
'respawn' redundant, and older ones can make with the current bash.
Line 150: uid, gid = getpwnam('vdsm')[2:4:]
@VDSMUSER@
--
To view, visit
http://gerrit.ovirt.org/4145
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69aae6b0b9529c80291d90c6ad14ff82b21aea53
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>