From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: client cert check for IPv4 mapped addresses
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/76197/7/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
PS7, Line 248: src_addr
I used loopback address for both so it won't fail. I will fix.
you would also need to handle the IPAddress(fqdn) case, I believe.
--
To view, visit
https://gerrit.ovirt.org/76197
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes