Martin Sivák has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as argument
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/28713/6//COMMIT_MSG
Commit Message:
Line 4: Commit: Martin Sivak <msivak(a)redhat.com>
Line 5: CommitDate: 2014-06-24 10:36:26 +0200
Line 6:
Line 7: Improve the _validateIoTuneParams so the params are passed as argument
Line 8:
Having this as pure function without side effect would be nice.
I will update the commit message, but moving the function elsewhere might be a nice
task for another patch (there is no obvious place at this moment).
Line 9: Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b
--
To view, visit
http://gerrit.ovirt.org/28713
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes