Yaniv Bronhaim has posted comments on this change.
Change subject: Removing support in sysv and upstart
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40726/6/vdsm.spec.in
File vdsm.spec.in:
Line 723: # only once after first installation.
Line 724: /bin/systemctl enable vdsmd.service >/dev/null 2>&1 || :
Line 725: /bin/systemctl enable vdsm-network.service >/dev/null 2>&1 || :
Line 726: /bin/systemctl enable supervdsmd.service >/dev/null 2>&1 || :
Line 727: fi
shouldn't be here.
Line 728: /bin/systemctl daemon-reload >/dev/null 2>&1 || :
Line 729: exit 0
Line 730:
Line 731: %preun
Line 733: %{_bindir}/vdsm-tool remove-config
Line 734: fi
Line 735: %systemd_preun vdsmd.service
Line 736: %systemd_preun vdsm-network.service
Line 737: %systemd_preun supervdsmd.service
this currently doesn't do anything - we didn't declare unit file for vdsmd. this
patch should rebase on the fix to
https://bugzilla.redhat.com/show_bug.cgi?id=1094936
Line 738: exit 0
Line 739:
Line 740: %postun
Line 741: if [ "$1" -ge 1 ]; then
--
To view, visit
https://gerrit.ovirt.org/40726
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes