Dan Kenigsberg has submitted this change and it was merged.
Change subject: guestagent: Simpler and safer disk mapping hash
......................................................................
guestagent: Simpler and safer disk mapping hash
Previously diskMapingHash was initialized to the magic value 0, or to
hash of a sorted json dump of the diskMapping dict. Now diskMappingHash
is always a real hash, and is read only.
The hash is computed automatically when the value of guestDiskMapping is
changed, and there is no way to forget to update the hash.
Change-Id: Ia914cf9860cef019b3040a3f034e479e6a93ed97
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/34625
Reviewed-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/guestagentTests.py
M vdsm/virt/guestagent.py
2 files changed, 28 insertions(+), 3 deletions(-)
Approvals:
Nir Soffer: Verified
Vinzenz Feenstra: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit
http://gerrit.ovirt.org/34625
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia914cf9860cef019b3040a3f034e479e6a93ed97
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server