Change in vdsm[master]: supervdsm: Fix race regarding instance ident

Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsm: Fix race regarding instance ident
......................................................................


Patch Set 2:

Can you please explain when this exception appears and why (refer to bz908068)? maybe
reproducer? I don't understand how this fix helps and it might be helpful to add ut
for that if we missed it until now.

We work on removing multiprocessing and use rypc instead in different patches due to bugs
in multiprocessing implementation, and it seems that the exception you saw is related to
the same manager.py bug. This change will just cause more conflicts. I don't see how
it helps more than just few arrangements in the code.. or am I missing something?

--
To view, visit http://gerrit.ovirt.org/11759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f548cb9ad805508cf75df691e0ab58b3278dc87
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server