Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/22462/7/vdsm/caps.py
File vdsm/caps.py:
Line 325: # representation of the device
Line 326: try:
Line 327: dev['name'] =
devXML.getElementsByTagName('name')[0].\
Line 328: childNodes[0].data
Line 329: capability = devXML.getElementsByTagName('capability')[0]
Current implementation's display capabilities are equivalent of
virt-manage
we only need to see address as well…just something to differentiate
devices with same name
Line 330: try:
Line 331: dev['product'] =
capability.getElementsByTagName('product')[0]\
Line 332: .childNodes[0].data
Line 333: dev['vendor'] =
capability.getElementsByTagName('vendor')[0].\
--
To view, visit
http://gerrit.ovirt.org/22462
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes