Nir Soffer has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
......................................................................
Patch Set 4:
Douglass, this his very big and risky patch. "make rpm works, clicking verified"
is not a valid way to verify it.
I suggest to separate to smaller patches that are easier to verify by the different
teams.
Also, in lot of places, we could not write correct code using atomic operations because of
the persist/unpersist requirement. Can we use now atomic write (write temp file, rename)
on node?
--
To view, visit
https://gerrit.ovirt.org/63715
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cca0cfa0e2254a5a8af6b3591ffe47689410415
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No