Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/9/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1190:
Line 1191: # Check that only the 'miimon' option is different from
default
Line 1192: # (TODO: but the kernel default for mode is balance-rr, 0)
Line 1193: cfg =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
Line 1194: self.assertEqual(cfg['BONDING_OPTS'],
'miimon=9')
If the default mode is 0 shouldn't you put before this
opts = 'mode=4 miimon=9'
and after the operation
cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
for element in cfg['BONDING_OPTS'].split(' '):
self.assertIn(element, opts.split(' '))
Line 1195:
Line 1196: # cleanup
Line 1197: networks = dict((NETWORK_NAME + str(num), {'remove':
True}) for
Line 1198: num in range(5))
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes