Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 269: if not self._stream.closed:
Line 270: return
Line 271:
Line 272: with self._term_lock:
Line 273: self._command.wait()
Taking the lock here means that terminate will wait forever if we
call from
If the stream is closed the command should exit very quickly.
Line 274:
Line 275: if self._command.returncode != 0:
Line 276: raise QImgError(self._command.returncode, "",
self.stderr)
Line 277:
--
To view, visit
https://gerrit.ovirt.org/33910
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes