Change in vdsm[master]: command: Store stdout and stderr to a log file

Francesco Romani has posted comments on this change.

Change subject: command: Store stdout and stderr to a log file
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility of the comments

https://gerrit.ovirt.org/#/c/59833/1//COMMIT_MSG
Commit Message:

PS1, Line 13: This change adds the possibility to store the stdout and stderr to a log
            : file
I'm not strongly against this change (so not -2), but I'd *really*, *really* try
to use it as last resort, because you are patching an already overly complex, poorly
tested, old piece of code on which half of Vdsm depends on - incidentally, the lesser
tested half.

So, how hard is to log the messages without changes to execCmd, and, more importantly, to
AsyncProc?

We already watch the process stdout. To add a filter which dumps the raw lines before they
enter into v2v.OutputParser should be painless.

Also, to collect in v2v.py all the process' stderr should be little pain.

Could this work for you?


-- 
To view, visit https://gerrit.ovirt.org/59833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a8b9afaa196729c8ab98f380a39833a9a0840cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com&gt;
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes