Nir Soffer has posted comments on this change.
Change subject: schema: customizable hook name
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/59251/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 7: type: enum
Line 8: values:
Line 9: 0: Auto numa balancing is not active
Line 10: 1: Auto numa balancing is active
Line 11: 2: Can't get the status(maybe not support in this kernel
Maybe create AutoNumaBalanchingStatusLegacy enum with the numbers, change the code to
accept both string and number, so we can deprecate the numeric version in the future. It
is pain to debug apis calls using numbers instead of text.
We have the same issue with storage apis.
Line 12: version)
Line 13:
Line 14: BalloonInfo: &BalloonInfo
Line 15: added: '3.1'
Line 1389: description: A mapping of hook script information
Line 1390: name: HookScriptAdditional
Line 1391: properties:
Line 1392: - description: A key for hook script information
Line 1393: name: custom_name
What is custom_name? do we check this value during verification?
Line 1394: type: *HookScriptInfo
Line 1395: type: object
Line 1396:
Line 1397: HookScriptInfoMap: &HookScriptInfoMap
--
To view, visit
https://gerrit.ovirt.org/59251
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb20039ef1d3bba32518dd23e6b30506cb77e0ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes