Dan Kenigsberg has posted comments on this change.
Change subject: Sometimes the FD number can be reused in the child process
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
sorry, I do not understand the bug in the test or its fix. would you (or someone else)
please explain it better?
....................................................
File tests/betterPopenTests.py
Line 58: self.assertEquals(p.stdout.read().strip(), "True")
Line 59:
Line 60: def testCloseFDs(self):
Line 61: fds = os.pipe()
Line 62: rpath = os.path.realpath("/proc/%d/fds/%d" % (os.getpid(),
fds[1]))
on my system it's called /proc/$$/fd/255
(notice the missing s)
Line 63: try:
Line 64: self._subTest("fds", [str(fds[1]), rpath], close_fds=True)
Line 65: finally:
Line 66: os.close(fds[0])
--
To view, visit
http://gerrit.ovirt.org/9591
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7044936fba8923297c76d9a2123215ec2b793548
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>