Yaniv Bronhaim has posted comments on this change.
Change subject: fileUtils.validateAccess ioprocess implementation
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/27120/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-04-27 18:58:10 +0300
Line 4: Commit: Yeela Kaplan <ykaplan(a)redhat.com>
Line 5: CommitDate: 2014-04-27 19:51:45 +0300
Line 6:
Line 7: fileUtils.validateAccess ioprocess implementation
i would add all the oop functions that available in one patch and all the
integration\replacements in the code in another one
Line 8:
Line 9: Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc
http://gerrit.ovirt.org/#/c/27120/1/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:
Line 79: def glob(self, pattern):
Line 80: return self._iop.glob(pattern)
Line 81:
Line 82:
Line 83: class _ioprocessFileUtils(object):
doesn't it deserve separate file. you'll add more functions, i'd put them all
together in oopsFunctionsImpl.py
Line 84: def __init__(self, iop):
Line 85: self._iop = iop
Line 86:
Line 87: def validateAccess(self, targetPath, perms=(os.R_OK | os.W_OK | os.X_OK)):
--
To view, visit
http://gerrit.ovirt.org/27120
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes