From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/7/tests/testValidation.py
File tests/testValidation.py:
Line 89: if options.enable_stress_tests:
Line 90: StressTestsPlugin.enabled = True
Line 91:
Line 92:
Line 93: class ThreadLeakPlugin(Plugin):
This does not make sense. Implementing empty method just to call the
super
this text appears under
Defining options
================
and I think it applies only to those plugins that want to define custom options. At the
moment, I see no reason to do that.
Line 94: """
Line 95: Check whether a test (or the code it triggers) leaks threads
Line 96: """
Line 97: name = 'thread-leak-check'
--
To view, visit
https://gerrit.ovirt.org/69040
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes