Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Refactor Pool.deleteImage()
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
I think, you have rebase problems here.
It looks like you need to split your previous commit and merge its deleteImage part with
this one
....................................................
File vdsm/storage/sd.py
Line 223:
Ah, you don't need this to commit
--
To view, visit
http://gerrit.ovirt.org/3464
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>