Ayal Baron has posted comments on this change.
Change subject: Rescan FC when rescanning for new multipath devices
......................................................................
Patch Set 5:
(1 comment)
....................................................
File vdsm/storage/multipath.py
Line 107: Should only be called from hsm._rescanDevices()
Line 108: """
Line 109:
Line 110: # First ask fc and iSCSI to rescan all of their sessions
Line 111: fc.rescan()
rescan on miss is definitely warranted in this situation.
of course the i/o is suspended only on these paths. These paths may be used by running
VMs and issuing the lip is quite problematic here.
refreshStorage is actually the place that worries me the most for this operation since it
is used in too many flows and is the last place I would like to have it.
Line 112: iscsi.rescan()
Line 113:
Line 114: # Now let multipath daemon pick up new devices
Line 115:
--
To view, visit
http://gerrit.ovirt.org/19539
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-HasComments: Yes