Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
......................................................................
Patch Set 11: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 173: spec = inspect.getargspec(func)
Line 174:
Line 175: @wraps(func)
Line 176: def wrapped(*args, **kwargs):
Line 177: saveRunningConf = (kwargs.get('configurator') is None and
I don't understand why we check that the configurator is None. This means that when we
get a setupNetworks from the engine, setupNetworks calls addNetwork with the Ifcfg
configurator so we never persist the added network to the running configuration.
Does anyone know the reasoning for this?
Line 178: config.get('vars', 'persistence') ==
'unified')
Line 179: if saveRunningConf:
Line 180: attrs = kwargs.copy()
Line 181: attrs.update(dict(zip(spec.args, args)))
--
To view, visit
http://gerrit.ovirt.org/16699
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Šebek <psebek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server