Dan Kenigsberg has posted comments on this change.
Change subject: Fix failed to add bridgeless network with skip libvirt
......................................................................
Patch Set 2: I would prefer that you didn't submit this
yes, skipLibvirt is an evil argument, born out of necessity to configure a network before
libvirtd is up. We should find a way to obsolete it.
Why did you use it? Out of bootstrapping, no one should.
Please move this param validation into _addNetworkValidation()
--
To view, visit
http://gerrit.ovirt.org/3919
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61fab631e8eecf3dc698a94d72858d7a72ade08
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>