Antoni Segura Puimedon has posted comments on this change.
Change subject: open: Change file() to open()
......................................................................
Patch Set 1: Code-Review+1
Thanks for this. It was long overdue that we'd get rid of the 'file' calling.
The only downside is that expanding 'f' to 'file' shadows the file
callable (which is considered a bad practice), though since it is shadowing something for
which there is little legitimate use, I'm ok with it.
--
To view, visit
http://gerrit.ovirt.org/26776
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80007044be1c648ebb668704731eae8b83366025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No