Yeela Kaplan has posted comments on this change.
Change subject: misc: remove cp parameter
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45613/2/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 448: raise se.InvalidParameterException(name, number)
Line 449: return n
Line 450:
Line 451:
Line 452: def rotateFiles(directory, prefixName, gen, persist=False):
This function does not work and its tests are wrong. We also cannot
use thi
If it's used for backing up domain metadata why would you want me to
remove it? what do you want instead?
Line 453: log.debug("dir: %s, prefixName: %s, versions: %s" %
Line 454: (directory, prefixName, gen))
Line 455: gen = int(gen)
Line 456: files = os.listdir(directory)
--
To view, visit
https://gerrit.ovirt.org/45613
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes