Ryan Harper has posted comments on this change.
Change subject: Move nfsSD.getFileList into misc so it can be reused
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/misc.py
Line 175: def getFileList(self, pattern, caseSensitive):
*sigh* not in this form. I had duplicated the code from nfsSD into localFS (as class
functions). As I was writing up the patch figured instead of the duplication I'd move
out and have two callers. Sorry, that was sloppy; I'll fix and test.
Line 181: filesList = self.oop.simpleWalk(basedir)
would it be OK to do something simpler for both NFS and local? Is it OK to leave it as-is
for both local and NFS callers?
--
To view, visit
http://gerrit.ovirt.org/3937
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b952669a22bd79ca6a38db5396efa63a87bc830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>