Francesco Romani has posted comments on this change.
Change subject: vm: Allow to use 'serial' or 'virtio' type consoles
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
quite good enough, tiny suggestion inside for further improvement.
https://gerrit.ovirt.org/#/c/25979/12/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:
Line 82: self.specParams = {}
Line 83:
Line 84: @property
Line 85: def isSerial(self):
Line 86: return self.specParams.get('consoleType', 'virtio') ==
'serial'
a constant instead of string 'serial' or 'virtio' would be nicer
Line 87:
Line 88: def getSerialDeviceXML(self):
Line 89: """
Line 90: Add a serial port for the console device if it exists and is a
--
To view, visit
https://gerrit.ovirt.org/25979
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes