Change in vdsm[master]: vm: Allow to use 'serial' or 'virtio' type consoles

Francesco Romani has posted comments on this change.

Change subject: vm: Allow to use 'serial' or 'virtio' type consoles
......................................................................

Patch Set 12: Code-Review+1

(1 comment)

quite good enough, tiny suggestion inside for further improvement.

https://gerrit.ovirt.org/#/c/25979/12/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 82:             self.specParams = {}
Line 83: 
Line 84:     @property
Line 85:     def isSerial(self):
Line 86:         return self.specParams.get('consoleType', 'virtio') == 'serial'
a constant instead of string 'serial' or 'virtio' would be nicer
Line 87: 
Line 88:     def getSerialDeviceXML(self):
Line 89:         """
Line 90:         Add a serial port for the console device if it exists and is a