Change in vdsm[master]: Fix getStorageDomainInfo() logic.

Ayal Baron has posted comments on this change.

Change subject: Fix getStorageDomainInfo() logic.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-05-12 04:58:11 +0300
Line 4: Commit:     Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
Line 5: CommitDate: 2013-05-16 10:46:09 +0300
Line 6: 
Line 7: Fix getStorageDomainInfo() logic.
Fix how? what are you doing? why?
Line 8: 
Line 9: Making repoStats pool independent.
Line 10: 
Line 11: Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f


Line 5: CommitDate: 2013-05-16 10:46:09 +0300
Line 6: 
Line 7: Fix getStorageDomainInfo() logic.
Line 8: 
Line 9: Making repoStats pool independent.
This patch is not making anything pool independent.  Please explain the motivation for it
properly.
Line 10: 
Line 11: Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f


....................................................
File vdsm/storage/hsm.py
Line 2665:         # remove this when we can stop supporting this API.
Line 2666:         info.update({'lver': -1, 'spm_id': -1,
'master_ver': 0})
Line 2667:         if info['role'] == sd.MASTER_DOMAIN:
Line 2668:             try:
Line 2669:                 pool = self.getPool(info['pool'][0])
To have a clue of what's going on here you need to split the code like so:

try:
    poolUUID = info['pool'][0]
except IndexError:
    self.log.error("Domain %s is marked as master but is not "
...
try:
    pool = self.getPool(poolUUID)
except se.StoragePoolUnknown:
...
Line 2670:             except IndexError:
Line 2671:                 self.log.error("Domain %s is marked as master but is not
"
Line 2672:                                "attached to any pool", sdUUID,
exc_info=True)
Line 2673:             except se.StoragePoolUnknown:


-- 
To view, visit http://gerrit.ovirt.org/14671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server